-
Notifications
You must be signed in to change notification settings - Fork 18
Better defaults for sea_ice_simulation
#535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Requires a new version of ClimaSeaIce which I am waiting for CliMA/ClimaSeaIce.jl#73 and CliMA/ClimaSeaIce.jl#72 to release |
What was the old interface? |
The old interface requires building the dynamics and the bottom boundary condition manually in the script because the ocean is not passed to SSS = view(ocean.model.tracers.S.data, :, :, grid.Nz)
bottom_heat_boundary_condition = IceWaterThermalEquilibrium(SSS)
SSU = view(ocean.model.velocities.u, :, :, grid.Nz)
SSV = view(ocean.model.velocities.v, :, :, grid.Nz)
coriolis = ocean.model.coriolis
τo = SemiImplicitStress(uₑ=SSU, vₑ=SSV, Cᴰ=sea_ice_ocean_drag_coefficient)
τua = Field{Face, Center, Nothing}(grid)
τva = Field{Center, Face, Nothing}(grid)
dynamics = SeaIceMomentumEquation(grid;
coriolis,
top_momentum_stress = (u=τua, v=τva),
bottom_momentum_stress = τo,
rheology = ElastoViscoPlasticRheology(),
solver = SplitExplicitSolver(150))
sea_ice = sea_ice_simulation(grid; bottom_heat_boundary_condition, dynamics, advection=WENO(order=7)) |
okay great, and I think it makes sense that this lives in ClimaOcean where we are doing the coupling. Possibly there will be other changes down the line to make stand-alone modeling easier with ClimaSeaIce (if that still makes sense even) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #535 +/- ##
==========================================
- Coverage 14.29% 14.18% -0.11%
==========================================
Files 48 48
Lines 2812 2833 +21
==========================================
Hits 402 402
- Misses 2410 2431 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I ll merge this because we also need it to capture the change of syntax of https://github.com/CliMA/ClimaSeaIce.jl/releases/tag/v0.3.0 |
the new interface will be
alternatively, to change the sea ice dynamics